build(deps-dev): bump rubocop-sorbet from 0.8.5 to 0.8.6 in /Library/Homebrew

[dependabot]

Bumps rubocop-sorbet from 0.8.5 to 0.8.6.

Commits

• 8a647e6 Bump version to v0.8.6
• ba484cc Merge pull request #263 from corsonknowles/main
• 79fc263 Add Sorbet/Refinement
• f4ca5d4 Merge pull request #262 from oneearedrabbit/patch-1
• f557ed6 Rescue ::Bundler::GemfileNotFound if sorbet-statis is not found
• 2d33fcf Merge pull request #261 from Shopify/dependabot/bundler/minor-and-patch-a3bd0...
• e0ff1a5 Bump the minor-and-patch group with 2 updates
• 115d959 Merge pull request #252 from Earlopain/documentation-url
• 07adee0 Set DocumentationBaseURL and DocumentationExtension
• f108619 Merge pull request #260 from Shopify/dependabot/bundler/minor-and-patch-fb0e3...
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[ZhongRuoyu]

+ brew style
formulary.rb:82:5: C: Sorbet/Refinement: Do not use Ruby Refinements library as it is not supported by Sorbet.
    refine Pathname do
    ^^^^^^^^^^^^^^^
formulary.rb:94:3: C: Sorbet/Refinement: Do not use Ruby Refinements library as it is not supported by Sorbet.
  using PathnameWriteMkpath
  ^^^^^^^^^^^^^^^^^^^^^^^^^

1325 files inspected, 2 offenses detected

[Bo98]

We can probably turn that cop off for now and let it fall under the scope of #17297 (if at all).

It's not quite clear what the solution would be anyway as we've been working against monkey patching, but monkey patching is what Sorbet prefers. In this case however, we're not actually defining new methods here so the cop isn't really flagging anything useful right now. Sorbet already would have flagged errors if it did.

[ZhongRuoyu]

We can probably turn that cop off for now and let it fall under the scope of #17297 (if at all).

It's not quite clear what the solution would be anyway as we've been working against monkey patching, but monkey patching is what Sorbet prefers. In this case however, we're not actually defining new methods here so the cop isn't really flagging anything useful right now. Sorbet already would have flagged errors if it did.

Makes sense. Thanks for the explanation!

[MikeMcQuaid]

It's not quite clear what the solution would be anyway as we've been working against monkey patching, but monkey patching is what Sorbet prefers. In this case however, we're not actually defining new methods here so the cop isn't really flagging anything useful right now. Sorbet already would have flagged errors if it did.

Agreed monkey patching is better for Sorbet.

The solution for most of these Refinement uses is to create a new class (possibly inheriting from the original class) and use that instead of modifying the existing usage. Alternatively, just deprecating these and relying on normal Ruby here instead.