Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining undef use in OS extensions to prepend #18378

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Sep 22, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Relates to #17998

Opening this as one big mess in draft form for folks to consider, very open to breaking this into digestible chunks.

I recommend hiding whitespace when reviewing.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Good to go when 🟢

@dduugg
Copy link
Member Author

dduugg commented Oct 2, 2024

(This is still on my radar, I anticipate working on it next week)

@dduugg dduugg marked this pull request as ready for review October 5, 2024 19:49
@dduugg
Copy link
Member Author

dduugg commented Oct 5, 2024

Reverting the ENV changes resolves the Ubuntu 20.04 failure. Going to merge the rest now per @MikeMcQuaid's blessing above. I'll work on the ENV piece separately and open another PR for that one.

@dduugg dduugg merged commit 3c51d0c into master Oct 5, 2024
34 checks passed
@dduugg dduugg deleted the no-undefs branch October 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants