Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing amount of a transaction #114

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

humdingerb
Copy link
Member

Only validate split items if the SplitView is actually shown, which makes the transaction a "split-transaction". Only then the original amount cannot be different that the split-total.

Fixes #100

@humdingerb
Copy link
Member Author

@dospuntos , hope I didn't step on your toes and the fix is good.

@dospuntos
Copy link
Contributor

@humdingerb no worries. Looks good, maybe disable (and reset) the amount box when fSplitContainer is visible?

Only validate split items if the SplitView is actually shown, which
makes the transaction a "split-transaction". Only then the original
amount cannot be different that the split-total.

When the SplitView is shown, disable the Amount text field.

When hiding the SplitView, resize window.

Fixes HaikuArchives#100
@humdingerb
Copy link
Member Author

Good call!
I amended the PR. Also resized the window when hiding the SplitView. That's been bothering me for a while... :)

Could you finish the Latin American Spanish, so we can export it all and release tomorrow?
Or do you have any other things that should be committed before release?

@dospuntos
Copy link
Contributor

I completed the Latin American translation. I don't have anything else that should be included, I think your PRs have included the most pressing items.

@humdingerb
Copy link
Member Author

OK, I mailed the translator for Catalan if he could finished that one, too. He didn't get backto me yet. Let's give it another day and release tomorrow, with or without a finished Catalan.

What do you say about #113 (comment) , go with the PR as is, or force capitalize category names?

@humdingerb
Copy link
Member Author

Assuming you're OK with how #113 does it for now. We can change later if needed.
Let's get that release out. :)

@humdingerb humdingerb merged commit f78c975 into HaikuArchives:master Aug 19, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Editing amount of existing transaction triggers split alert
2 participants