Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support kubectl-style plugin #175

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 25, 2023

What's the feature

We can use the kubectl-sytle plugin now. For example, if we put the custom plugin in the /usr/local/bin, like gtctl-foo, we can use it like this:

GTCTL_PLUGIN_PATHS=/usr/local/bin gtctl foo 1 2 3

The gtctl will search the plugin from the GTCTL_PLUGIN_PATHS(separate by :) and run it.

Related issue: #24.

@zyy17 zyy17 requested a review from shawnh2 October 25, 2023 07:11
@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (5e2fb15) 37.79% compared to head (889c3c3) 38.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    37.79%   38.18%   +0.38%     
===========================================
  Files           14       15       +1     
  Lines         1233     1286      +53     
===========================================
+ Hits           466      491      +25     
- Misses         668      690      +22     
- Partials        99      105       +6     
Files Coverage Δ
pkg/plugins/manager.go 47.16% <47.16%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shawnh2 shawnh2 merged commit 72efdf2 into GreptimeTeam:develop Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants