Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expr for altering table attributes #192

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Oct 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add expr for altering table attributes like TTL

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@v0y4g3r v0y4g3r force-pushed the feat/add-modify-table-attr-expr branch from 38948d4 to f81189a Compare October 17, 2024 05:15
 Added ChangeTableAttributes to AlterRequest in server.proto

 - Introduced ChangeTableAttributes message handling in AlterRequest.
 - Updated server.pb.cc and server.pb.h to include logic for new ChangeTableAttributes.
 - Altered Java Server class to support ChangeTableAttributes.
 - Incremented descriptor sizes and adjusted field offsets in server.pb.cc.
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants