Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RangeSelect #184

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add RangeSelect #184

wants to merge 2 commits into from

Conversation

etolbakov
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link

GreptimeTeam/greptimedb#4358

What's changed and what's your intention?

Declare RangeSelect definition

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@etolbakov
Copy link
Contributor Author

etolbakov commented Jul 26, 2024 •
edited
Loading

I have several questions about RangeSelect declaration:

  1. what would be a suitable location for it? At the moment I put it under substrait_extension but not sure if this is correct.
  2. did I get it correct that Arc<LogicalPlan> and DFSchemaRef could be skipped from the definition?
  3. I'm not too sure how should I go about the following types.
  • DataType
  • Expr
  • Duration

@killme2008 @waynexia could you please help me with it?

@etolbakov
Copy link
Contributor Author

bumping up in case the notification was missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@etolbakov