[pcsc] Compile simclist, tokenparser with PC/SC #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the compilation of these two mini-libraries from the CCID Driver to PC/SC-Lite. Unlike in the upstream *nix implementation where both CCID and PC/SC-Lite ship with their own version of these mini-libraries, we have to choose one of the copies since we link everything into a single WebAssembly executable. Previously we semi-aribtrarily chose to put the compilation and linking into the CCID Driver's makefile, however this doesn't work out nicely with the plan to add more drivers.
Fabian-Sommer
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the compilation of these two mini-libraries from the CCID Driver to PC/SC-Lite.
Unlike in the upstream *nix implementation where both CCID and PC/SC-Lite ship with their own version of these mini-libraries, we have to choose one of the copies since we link everything into a single WebAssembly executable. Previously we semi-aribtrarily chose to put the compilation and linking into the CCID Driver's makefile, however this doesn't work out nicely with the plan to add more drivers. Our PC/SC-Lite Makefile is a better place for a shared thing like this.