Better unit tests #100
Better unit tests #100
Conversation
Return a 404 when version doesn’t exist for a platform
|
I fixes #95, which was breaking the whole update system (stable will have been updated to unstable, etc). @mzmousa can you look at the spec in |
|
@jsloyer Since you are also interested in update channels, please look at the spec. I want to be sure that we all agree on update channels:
|
|
@SamyPesse This is the way I'm currently using it - I'm most just following how Squirrel-updates-server does it since it worked out so conveniently:
What do you mean by this, specifically? I think I agree with having the stable version update as a fallback if something were to go wrong on the alpha or beta versions, but would we be able to have an error or something sent back in the JSON to specify why the fallback occured? :) |
|
I agree that |
|
An other case I realize now: if you had a version As a comparison, this is exactly the behavior implemented in electron-release-server: see here and here. |
| var nuts = require('../lib'); | ||
|
|
||
| var config = { | ||
| repository: 'SamyPesse/nuts-testing', |
There was a problem hiding this comment.
Wouldn't it be more handy to implement and use a TestBackend (inherits from Backend) in which we could inject mock data? It would permit to test a large range of scenarios.
The GithubBackend looks thin and dumb enough so that test cases with TestBackend will cover a similar amount of logic. Moreover, some test cases (functional) can use the GithubBackend with the nuts-testing repo.
|
|
||
| platform = platforms.detect(platform); | ||
|
|
||
| return that.versions.filter({ | ||
| tag: '>='+tag, | ||
| platform: platform, | ||
| channel: channel | ||
| channel: channel, | ||
| stripChannel: true |
There was a problem hiding this comment.
I don't get why stripChannel should be striped.
Imagine we have a version 0.1.53-beta in releases (0.1.53 is not in release yet):
With stripChannel=true: /update/channel/beta/darwin_x64/0.1.53 leads to 0.1.53-beta => will install a lower version
With stripChannel=false: /update/channel/beta/darwin_x64/0.1.53 leads to 204
There was a problem hiding this comment.
I tried to remove the stripChannel but I ran into other problem: I was not able to update an user on a stable version to a beta version, because of how semver.satisfies handle the prerelease tag. Such a nightmare..
|
Hey @SamyPesse, @alexstrat, I've tested this PR and it fixes the issue I had on I'll use this PR as my main update server (as |
|
Hi, I merged the project to a new repo to start maintain it, I would be glad if you can put your pull request here : https://github.com/loprima-l/nuts-2 |
👷 WORK IN PROGRESS 🚧
This PR adds more (and better) unit tests to Nuts. Basically download and updates will be correctly unit tested to avoid breaking changes when trying to contribute to the repository.
This PR will also add standard HTTP status codes to responses, and fix #56.
I was hoping to move code to ES6 (cleaner code, especially for classes) and use Babel before npm releases, but I can't find a solution to make it work correctly while supporting the Heroku Deploy button (I'm open to ideas!).
I'll release a new version 🚀 as soon as all endpoints are correctly tested, and once I'm sure merging #95 did not break Nuts for GitBook and other devs.
XOXO 💕