add maxItems option to scope prompt #104
Conversation
Fixed glitch on small height screen for long scopes list. Base on @clack/[email protected] via bombshell-dev/clack#174
|
Hey thanks for the contribution! @exdeniz Does this happen on |
| @@ -107,6 +107,7 @@ export async function main(config: Output<typeof Config>) { | |||
| let commit_scope = await p.select({ | |||
| message: "Select a commit scope", | |||
| initialValue: config.commit_scope.initial_value, | |||
| maxItems: config.commit_scope.max_items, | |||
There was a problem hiding this comment.
On most PRs I would say this is exactly what we want to do (thanks for taking the time to understand the repo!). - I think in this case we could just bump the version and put maxItems: Infinity (Or just a relatively high number lol) here and on commit_type.
IIRC (maybe it has changed) clack doesn't support filter / search on select. As an example, if we had 10 scopes but a max_items of 5, we don't have a way to filter where it would show any of the 5 hidden items.
There was a problem hiding this comment.
I added max_items for commit_type. Yes, we have the ability to specify what will be displayed, but if we specify initialValue then p.select will correctly move through the list:
There was a problem hiding this comment.
👀 I misunderstood how max-items works. - I'll merge :), thanks again!
|
🎉 This PR is included in version 1.15.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixed glitch on small height screen for long scopes list. Base on @clack/[email protected] via bombshell-dev/clack#174