chore: Review fixes

CosmWasm · Oct 11, 2024 · 2da70e6 · 2da70e6
1 parent 06c5a69
commit 2da70e6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/sylvia-derive/src/contract/communication/reply.rs b/sylvia-derive/src/contract/communication/reply.rs
@@ -276,7 +276,9 @@ impl<'a> ReplyData<'a> {
         } else if is_failure {
             quote! { #sylvia ::cw_std::ReplyOn::Error }
         } else {
-            // This should never happen
+            // This should never happen.
+            // We parse only the `Success`, `Failure` and `Always` values which are covered above.
+            // Handling the `Never` value wouldn't make sense as we would create a dead handler.
             quote! { #sylvia ::cw_std::ReplyOn::Never }
         }
     }

diff --git a/sylvia/tests/reply.rs b/sylvia/tests/reply.rs
@@ -328,6 +328,11 @@ mod tests {
         let last_reply = contract.last_reply().unwrap();
         assert_eq!(last_reply, FAILURE_REPLY_ID);
 
+        // Should send the cosmos message
+        contract.send_cosmos_messages().call(&owner).unwrap();
+        let last_reply = contract.last_reply().unwrap();
+        assert_eq!(last_reply, ALWAYS_REPLY_ID);
+
         // Should return error if unknown reply ID received
         let unknown_reply_id = 42u64;
         let err = contract