Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4286 credential management error handling #2290

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented Oct 17, 2024

🎫 Ticket

https://jira.cms.gov/browse/DPC-4286

🛠 Changes

  • API handles bad characters in signature snippet
  • TextArea component shows errors
  • New public key, client token, and ip address forms show errors on fields
  • Public key, client token, and ip address controllers delegate all field checking to managers, send errors to components
  • Public key, client token, and ip address managers check all input, return errors
  • CredentialManager concern added to dedupe code

ℹ️ Context

Original error handling was very primitive, pending decisions by content. Now we have the content.

🧪 Validation

Automated and manual testing

Client Tokens

Blank fields

ct-blank

Label too long

ct-invalid

Server error

ct-server-error

IP Addresses

Blank fields

ip-blank

Invalid input

ip-invalid

Already at maximum number of ip addresses

ip-max

Server error

ip-server-error

Public Keys

Blank fields

pk-blank

Bad inputs

pk-invalid

Signature doesn't match

pk-snippet-not-match

Private key

pk-private-key

Server error

pk-server-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant