Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Use Ubuntu 22.04 runner for PHP 7.0 tests #39779

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Oct 15, 2024

This uses the tests matrix to pass through ubuntu-latest as the default runner, with an override to use the ubuntu-22.04 runner for PHP 7.0 tests.

Proposed changes:

As of yesterday, our tests on trunk started timing out:

https://github.com/Automattic/jetpack/actions/workflows/tests.yml?query=branch%3Atrunk

We use ubuntu-latest in our workflows, and that runner is now using Ubuntu 24.04:

actions/runner-images#10636

For some reason, PHP 7.0 + Ubuntu 24.04 has major network issues, which results in double the time to run (and in most cases, a timeout). Given nothing obvious from our end is causing this and support for PHP 7.0 will be dropped with WP 6.7 (mid-November), it's easiest to just switch to the old runner (ubuntu-22.04) for PHP 7.0 tests.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Verify the PHP 7.0 tests are on the ubuntu-22.04 runner, e.g.:
https://github.com/Automattic/jetpack/actions/runs/11354027780/job/31580361443?pr=39779

@tbradsha tbradsha added the Actions GitHub actions used to automate some of the work around releases and repository management label Oct 15, 2024
@tbradsha tbradsha requested a review from a team October 15, 2024 20:39
@tbradsha tbradsha self-assigned this Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 15, 2024
@tbradsha tbradsha added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 15, 2024
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and seems to work.

@tbradsha tbradsha merged commit 70ef2cd into trunk Oct 15, 2024
58 of 59 checks passed
@tbradsha tbradsha deleted the fix/gh_action_runner_for_tests branch October 15, 2024 20:52
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants