Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eni): add selection policy #636

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

exherb
Copy link
Contributor

@exherb exherb commented May 28, 2024

No description provided.

@exherb exherb force-pushed the main branch 2 times, most recently from 5704e51 to 1c3ddd3 Compare May 28, 2024 03:41
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 23.67%. Comparing base (498d2c3) to head (781da2e).

Files Patch % Lines
pkg/eni/manager.go 58.33% 5 Missing ⚠️
daemon/config.go 75.00% 2 Missing ⚠️
daemon/daemon.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   23.42%   23.67%   +0.25%     
==========================================
  Files          62       62              
  Lines        6477     6491      +14     
==========================================
+ Hits         1517     1537      +20     
+ Misses       4717     4710       -7     
- Partials      243      244       +1     
Flag Coverage Δ
unittests 23.67% <61.90%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exherb exherb force-pushed the main branch 2 times, most recently from ab053b0 to 6b66c29 Compare May 28, 2024 08:58
daemon/config.go Outdated Show resolved Hide resolved
pkg/eni/manager.go Show resolved Hide resolved
@exherb exherb force-pushed the main branch 2 times, most recently from 694f471 to d36089b Compare May 30, 2024 07:56
@exherb exherb requested a review from l1b0k May 31, 2024 14:01
@l1b0k
Copy link
Collaborator

l1b0k commented Jun 5, 2024

@exherb go test failed

@exherb
Copy link
Contributor Author

exherb commented Jun 15, 2024

@exherb go test failed

I will fix it

@exherb
Copy link
Contributor Author

exherb commented Jun 17, 2024

@l1b0k 测试应该能过了, 不过不知道为啥测试没跑

types/daemon/config.go Outdated Show resolved Hide resolved
@exherb
Copy link
Contributor Author

exherb commented Jul 3, 2024

@l1b0k please review again, sorry for the delay.

@l1b0k l1b0k merged commit 677cd12 into AliyunContainerService:main Jul 4, 2024
9 checks passed
@l1b0k
Copy link
Collaborator

l1b0k commented Jul 4, 2024

@exherb Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants