Change window To self
#528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because when using `window` only web pages can use this. But when using `self`, then web workers can use it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because when using
windowonly web pages can use this. But when usingself, then web workers can use it too.What's The Use?
I encountered this when I was trying to use the resumable file upload inside a web worker (I had to, because I needed some synchronous, blocking, pre-processing on the file) then all the window.* methods would blow up. Such scenario doesn't seem very improbable, considering the nature of files & IO.
Backwards Compatible?
The "resumable.js" uses
window.setTimeoutin multiple cases and alsowindow.resumable = resumableat the end of the file. As a matter of fact all these cases can be safely changed toself.*(look here). I changed it and it seems to work both on web pages & web workers too.