Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent compatibility problems without increasing minor version #1264

Open
erikvanoosten opened this issue Jun 26, 2024 · 0 comments
Open

Prevent compatibility problems without increasing minor version #1264

erikvanoosten opened this issue Jun 26, 2024 · 0 comments

Comments

@erikvanoosten
Copy link
Collaborator

Zio-kafka has mima checks but as soon as there is compatibility problem they need to be disable to prevent every build to fail. This caused the last release to have version 2.7.5 instead of 2.8.0.

We can prevent this by enabling Mima only when we build from a tag (which indicates a release). The check will run against the same minor version, but with patch set to 0 (if patch version is already 0 no mima check is needed). If we're not building against a tag, the compatibility check stays disabled.

There is a downside: we won't notice backward incompatibility until we release. But I think this is better than what we have now. At least it will prevent wrong releases.

Variation: we always run the mima check, but it can only fail the whole build when we're building from a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant