Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use error, warn, verbose, or silly to replace info for our log level #329

Open
huan opened this issue Feb 28, 2022 · 0 comments
Open

Use error, warn, verbose, or silly to replace info for our log level #329

huan opened this issue Feb 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@huan
Copy link
Member

huan commented Feb 28, 2022

I saw we are using lots of log.info(...) in the puppet code, which is not a necessary message to the end users.

We should:

  1. Use warn when there's something we need the user to notice
  2. Use error when there's any error
  3. Use verbose for tracking the methods (always be the first call inside a method)
  4. Use silly to output more debug information.

NEVER use info inside a puppet.

Thank you very much.

@huan huan added the enhancement New feature or request label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant