Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Timestamp for timestamp in gRPC #108

Open
huan opened this issue Feb 19, 2021 · 0 comments
Open

Use Timestamp for timestamp in gRPC #108

huan opened this issue Feb 19, 2021 · 0 comments
Labels
breaking Breaking changes enhancement New feature or request

Comments

@huan
Copy link
Member

huan commented Feb 19, 2021

According to https://cloud.google.com/apis/design/naming_convention#method_names

To represent a point in time independent of any time zone or calendar, google.protobuf.Timestamp should be used, and the field name should end with time, such as start_time and end_time.

Currently, we are using uint64. Need to follow the Google Naming Convention.

See also: API style guidelines from Envy Proxy Data Plane API

For time-related fields, prefer using the well-known types google.protobuf.Duration or google.protobuf.Timestamp instead of raw integers for seconds.

@huan huan added enhancement New feature or request breaking Breaking changes labels Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant