Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A readable example #147

Closed
noncom opened this issue Feb 15, 2019 · 6 comments
Closed

A readable example #147

noncom opened this issue Feb 15, 2019 · 6 comments
Labels

Comments

@noncom
Copy link

noncom commented Feb 15, 2019

Looking into the usage example hits you with a barely formatted wall of text for the carousel template, which is very hard to read, especially when you at first jump between it and the component JS code a lot to see what goes where.

Could you please extract the template into a separate code block and apply formatting and language highlight to it?

@sheikalthaf
Copy link
Collaborator

Hi @noncom ,

Please check this demo for the usage of this carousel

@sheikalthaf sheikalthaf pinned this issue Mar 4, 2019
@tayambamwanza
Copy link

@sheikalthaf Thanks, that's much better, but still hard to grasp for a beginner, the best would just be the config object, followed by the array of images, and the template binding.

Just those core concepts would be perfect, adding change detection and everything else can come in as an advanced part of documentation

@tayambamwanza
Copy link

I think an example with only the simple example as well, leave out routing etc, just an isolated simple carousel.

Thank you for all the hard work, I can't even begin to imagine how much work you've put in to this, just to help others, I'm deeply grateful.

@tayambamwanza
Copy link

Something as simple as this would be very welcoming

https://stackblitz.com/edit/ngu-carousel-demo-n3rfvf

Then later in the docs you can add more complicated examples

Copy link

github-actions bot commented Jul 5, 2024

This issue has been automatically marked as stale because it has not had recent activity for 6 months. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

github-actions bot commented Jul 5, 2024

Closing this issue due to no activity for 6 months.

@github-actions github-actions bot added the Stale label Jul 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants