Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the input image (16K * 16K) is too large, the generated heif image cannot be opened. The prompt file is damaged. #1275

Open
yjszyd0813 opened this issue Aug 20, 2024 · 10 comments

Comments

@yjszyd0813
Copy link

When the input image (16K * 16K) is too large, the generated heif image cannot be opened. The prompt file is damaged. How to solve this problem? How to improve the encoding speed? To test encoding 5K * 5K images into HEIF files, 1.2S is required

@yjszyd0813
Copy link
Author

The libheif built through vcpkg is missing secure_limits.h

@bradh
Copy link
Contributor

bradh commented Aug 20, 2024

The libheif built through vcpkg is missing secure_limits.h

This seems like a different issue and probably would be better raised on a new ticket.

@bradh
Copy link
Contributor

bradh commented Aug 20, 2024

When the input image (16K * 16K) is too large, the generated heif image cannot be opened. The prompt file is damaged. How to solve this problem? How to improve the encoding speed? To test encoding 5K * 5K images into HEIF files, 1.2S is required

These look like two different issues (1 = the corrupt file, 2 = encoding speed). Could you consider splitting them up. Also can you edit the issue(s) to provide more details for exact reproduction?

@farindk
Copy link
Contributor

farindk commented Aug 20, 2024

The libheif built through vcpkg is missing secure_limits.h

This seems like a different issue and probably would be better raised on a new ticket.

security_limits.h is no installed header. I do not understand what "is missing" means.

@farindk
Copy link
Contributor

farindk commented Aug 20, 2024

When the input image (16K * 16K) is too large, the generated heif image cannot be opened.

Opened where? The issue is probably that the viewer application tries to load the whole image into a single "texture" and fails to do so because 16K * 16K is about 1 GB uncompressed. For that sizes, the viewer application has to support loading the image in tiles.

@yjszyd0813
Copy link
Author

The libheif built through vcpkg is missing secure_limits.h

This seems like a different issue and probably would be better raised on a new ticket.

security_limits.h is no installed header. I do not understand what "is missing" means.

Sorry, I meant that “security_limits.h” is not compiled or built by vcpkg. I was unable to find the relevant parameters in it.

@farindk
Copy link
Contributor

farindk commented Aug 20, 2024

Sorry, I meant that “security_limits.h” is not compiled or built by vcpkg. I was unable to find the relevant parameters in it.

I still don't understand the issue. security_limits.h is just an internal file that contains a couple of constants. That file is used when building the library, but it is not accessible in any way from outside.

@bradh
Copy link
Contributor

bradh commented Aug 20, 2024

Sorry, I meant that “security_limits.h” is not compiled or built by vcpkg. I was unable to find the relevant parameters in it.

https://github.com/strukturag/libheif/blob/master/libheif/security_limits.h

@silverbacknet
Copy link

vcpkg is still on 1.17.6 but that's only the most minor difference in the header, and the few patches it has don't touch anything about the file. yjszyd0813's hunch is definitely a red herring.

I haven't looked at the new tiling code much, does it automatically tile images too large for the codec now? Like AV1 maxes out at 4096 × 2304, and beyond that must be tiled at either the codec or HEIF level.

@farindk
Copy link
Contributor

farindk commented Aug 20, 2024

I haven't looked at the new tiling code much, does it automatically tile images too large for the codec now? Like AV1 maxes out at 4096 × 2304, and beyond that must be tiled at either the codec or HEIF level.

There is an API to encode images tile by tile and also decode it in parts. The intention is to support even huge dimensions (think > 1M x 1M). For those dimensions it's not possible anymore to hold an image in memory. Might be that we add an API for automatic tiling for smaller images. That's trivial to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants