From 05871acf7599748e1d23b5a8c6c977180ce2263d Mon Sep 17 00:00:00 2001
From: Kai Kummerer <kai.kummerer@stackit.de>
Date: Fri, 8 Dec 2023 09:59:23 +0100
Subject: [PATCH] Fix(secgroups): ICMP Echo Request being blocked

---
 .../loadbalancer/loadbalancer_controller_test.go              | 4 ++--
 internal/helper/loadbalancer.go                               | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/controllers/yawol-controller/loadbalancer/loadbalancer_controller_test.go b/controllers/yawol-controller/loadbalancer/loadbalancer_controller_test.go
index aef33150..8b1e2a4d 100644
--- a/controllers/yawol-controller/loadbalancer/loadbalancer_controller_test.go
+++ b/controllers/yawol-controller/loadbalancer/loadbalancer_controller_test.go
@@ -905,8 +905,8 @@ func getDesiredSecGroups(remoteID string) []rules.SecGroupRule {
 				EtherType:    string(etherType),
 				Direction:    string(rules.DirIngress),
 				Protocol:     string(rules.ProtocolICMP),
-				PortRangeMin: 1,
-				PortRangeMax: 8,
+				PortRangeMin: 8,
+				PortRangeMax: 0,
 			},
 		)
 	}
diff --git a/internal/helper/loadbalancer.go b/internal/helper/loadbalancer.go
index 8c132e9f..18eecb42 100644
--- a/internal/helper/loadbalancer.go
+++ b/internal/helper/loadbalancer.go
@@ -218,8 +218,8 @@ func GetDesiredSecGroupRulesForLoadBalancer(r record.EventRecorder, lb *yawolv1b
 				EtherType:    string(etherType),
 				Direction:    string(rules.DirIngress),
 				Protocol:     string(icmpProtocol),
-				PortRangeMin: 1,
-				PortRangeMax: 8,
+				PortRangeMin: 8, // icmp_type
+				PortRangeMax: 0, // icmp_code
 			})
 	}