From 9a51574e17ff40a6cac7cc2d965b2e60e047576b Mon Sep 17 00:00:00 2001 From: Kurt McKee Date: Fri, 23 Aug 2024 07:04:25 -0500 Subject: [PATCH] Fix `make test` (#287) **Description:** `make test` references an undefined variable, `APP_PORT`, which causes the the `docker-compose` command's `-p` argument to be malformed: ``` docker-compose run -p :8080 ... ^--- missing the left-side port! ``` **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) _The test failure in CI appears to be unrelated to this change._ - [ ] Documentation has been updated to reflect changes, if applicable - [ ] Changes are added to the changelog --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 26ed0361..9a3f23ce 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ #!make APP_HOST ?= 0.0.0.0 -EXTERNAL_APP_PORT ?= ${APP_PORT} +EXTERNAL_APP_PORT ?= 8080 ES_APP_PORT ?= 8080 ES_HOST ?= docker.for.mac.localhost