Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should data-modules respect old private type index location? #111

Open
angelo-v opened this issue May 10, 2024 · 0 comments
Open

Should data-modules respect old private type index location? #111

angelo-v opened this issue May 10, 2024 · 0 comments

Comments

@angelo-v
Copy link
Collaborator

If the type index exists, but it’s declared in the profile, it doesn’t work. Now, I understand the rationale behind this, because I am declaring solid:privateTypeIndex in the profile which is probably not the best idea. I think I’m doing this because that’s how it worked before in SolidOS (the document itself is private though, so it shouldn’t be that much of a problem). What your library expects, which seems to be better, is that it’s declared in a pim:preferencesFile, which I assume should be private. The thing is that the type-indexes spec is still a draft, so I’m not sure if I should change the way my apps work until that’s stable :/. Also, there is already some data in the wild using that old approach, so maybe the library should support it as well; even if it’s just to read data and not to create new type indexes.

https://forum.solidproject.org/t/request-for-developer-feedback-contacts-data-module/7372/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant