Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: enable --skip-tls-verify during the build phase #2346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teacher2018
Copy link

Describe what this PR does / why we need it

Command "sealer build", kubefileparse.imageEngine not support http shema in pull phase automatically. so we can do something to expand functionality.

Does this pull request fix one issue?

Fixes #2345

Describe how you did it

Add --skip-tls-verify option to "sealer build" command, then kubefileparse.pull() can get it

Describe how to verify it

Reference issue #2345 to reproduce , without http schema error output

Special notes for reviews

@github-actions github-actions bot added test ImageBuilding related to all staff with image building labels Sep 7, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.27%. Comparing base (005f904) to head (d4e2090).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (005f904) and HEAD (d4e2090). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (005f904) HEAD (d4e2090)
unit-tests 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2346       +/-   ##
==========================================
- Coverage   20.50%   1.27%   -19.24%     
==========================================
  Files          96     165       +69     
  Lines        9128   13846     +4718     
==========================================
- Hits         1872     176     -1696     
- Misses       7001   13654     +6653     
+ Partials      255      16      -239     
Flag Coverage Δ
e2e-tests 1.27% <ø> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sealer build fail with http schema
2 participants