Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection Banner and Logo not appearing #12

Closed
2 tasks
DraxIndustries79 opened this issue Aug 3, 2023 · 5 comments
Closed
2 tasks

Collection Banner and Logo not appearing #12

DraxIndustries79 opened this issue Aug 3, 2023 · 5 comments
Assignees
@orangewolf

Comments

@DraxIndustries79
Copy link

Story

Collection Banner and Logo images uploaded are not appearing on the show page for that collection.
Example: https://kevin-test-aug-23.hykuup.com/collections/19b121b2-7a6c-4050-ac9e-448371c622b1?locale=en

Image

Acceptance

  • Uploaded Collection Banner appears on show page
  • Uploaded Collection Logo appears on show page

Testing

Upload a logo and a banner for a collection, save, then navigate to public view for that collection landing page. Logo and Banner should appear.
@jillpe
Copy link

jillpe commented Aug 10, 2023 •
edited
Loading

Helpful places to start:

@kirkkwang kirkkwang added the blocked other work must be completed first label Aug 22, 2023
@kirkkwang
Copy link
Contributor

Blocked until Rob makes sure all the changes he had to make get consolidated properly

@jillpe jillpe removed the blocked other work must be completed first label Aug 28, 2023
@jillpe
Copy link

jillpe commented Aug 28, 2023

No longer blocked

@ShanaLMoore ShanaLMoore assigned orangewolf and unassigned orangewolf Aug 30, 2023
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Aug 30, 2023 •
edited
Loading

Rob said that he would look into this and get back with us. He mentioned something about going back and forth with the community about where the logos should live. There is no branding directory in the server. Locally it's looking to put in public/branding. We need confirmation about what directory it should be.

@ShanaLMoore ShanaLMoore added the blocked other work must be completed first label Aug 30, 2023
ShanaLMoore added a commit that referenced this issue Nov 17, 2023
@ShanaLMoore
🐛 [i12] add symblink to public/branding
b78bc9c 
This commit is required to resolve the issue with uploading images from the Collections' branding tab. Because the symlink wasn't established, a user would not be able to see the images they uploaded even though the path correctly exists.

Issue:
- #12

Related PR:
- scientist-softserv/atla-hyku#187
@ShanaLMoore ShanaLMoore mentioned this issue Nov 17, 2023
Closed
kirkkwang added a commit that referenced this issue Mar 18, 2024
@kirkkwang
Merge pull request #12 from samvera-labs/update-work-resource-generator
0bdd510 
Update `HykuKnapsack::WorkResourceGenerator`
@ShanaLMoore ShanaLMoore removed the blocked other work must be completed first label Jun 13, 2024
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jun 13, 2024 •
edited
Loading

see #238

@ShanaLMoore ShanaLMoore mentioned this issue Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orangewolf orangewolf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@orangewolf @ShanaLMoore @kirkkwang @DraxIndustries79 @jillpe