Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overflowing enum cast from ICEing #131909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent overflowing enum cast from ICEing #131909

wants to merge 1 commit into from
+76 −3

Conversation

clubby789
Copy link
Contributor

Fixes #131902

Inventing a zero constant here doesn't feel great. I think ideally the error would mark this type as erroneous and it wouldn't reach this point

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2024
jieyouxu
jieyouxu reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delaying a bug all the way in THIR seems a bit strange, but I also don't know what's the proper handling for this.

@jieyouxu
Copy link
Member

jieyouxu commented Oct 19, 2024 •
edited
Loading

r? types

@rust-lang rust-lang deleted a comment from rustbot Oct 19, 2024
@rustbot rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Oct 19, 2024
@rustbot rustbot assigned jackh726 and unassigned jieyouxu Oct 19, 2024
@jieyouxu jieyouxu removed the T-types Relevant to the types team, which will review and decide on the PR/issue. label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@jackh726 jackh726

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in rustc when casting invalid enum discriminant
4 participants
@clubby789 @rustbot @jieyouxu @jackh726