Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark unexpected variant res suggestion as having placeholders #131899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark unexpected variant res suggestion as having placeholders #131899

wants to merge 1 commit into from
+1 −1

Conversation

compiler-errors
Copy link
Member

Fixes #131878

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2024
@lqd
Copy link
Member

lqd commented Oct 18, 2024

I guess this is annoying to test.

r? lqd @bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2024

📌 Commit 1617501 has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned TaKO8Ki Oct 18, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2024
@matthiaskrgr
Rollup merge of rust-lang#131899 - compiler-errors:placeholder, r=lqd
4031762 
Mark unexpected variant res suggestion as having placeholders

Fixes rust-lang#131878
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2024
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2024
@bors
Auto merge of rust-lang#131903 - matthiaskrgr:rollup-bqqaah0, r=matth…
7879503 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#127462 (std: uefi: Add basic Env variables)
 - rust-lang#131537 (Fix range misleading field access)
 - rust-lang#131899 (Mark unexpected variant res suggestion as having placeholders)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagnostic for E0533 (expected value, found struct variant) has hint with incorrect applicability
5 participants
@compiler-errors @rustbot @lqd @bors @TaKO8Ki