Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between refactor_osrfbuild branch and refactor (ROS) #89

Open
3 tasks
j-rivero opened this issue Dec 22, 2020 · 0 comments
Open
3 tasks

Differences between refactor_osrfbuild branch and refactor (ROS) #89

j-rivero opened this issue Dec 22, 2020 · 0 comments

Comments

@j-rivero
Copy link
Contributor

The issue list the differences between the branches maintained for ROS and osrfbuild with the hope of merging both at some point. This should be the plain comparison of both branches. These are the points I think useful:

  • There are hardcoded values in the DistributionsFile class.
  • I've changed some warnings to failures since that was generating a big load of debugging instead of failing fast. This might be dangerous to change in the ROS invocations.
  • Added a bit of code not to override distributions files in repo when running without --commit and to be sure that the new generated distributions file (from reprepro) is the same than previous one in the repo (mainly by chef).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant