Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error handling by OAIPMHGenerator #9

Open
markmatney opened this issue Aug 4, 2017 · 2 comments
Open

better error handling by OAIPMHGenerator #9

markmatney opened this issue Aug 4, 2017 · 2 comments

Comments

@markmatney
Copy link
Contributor

The code currently has no checks for thrown exceptions.
@hariharshankar
Copy link
Contributor

Could you please elaborate on this?

@markmatney
Copy link
Contributor Author

My generator doesn't do error handling very well, in that for example, it's possible that the call to requests.get could return a 404, which should be checked (in which case there would be no XML content, and trying to parse the response body with BeautifulSoup may throw an error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hariharshankar @markmatney