You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This gives the user explicit control over the agent_portrayal and the propertylayer_portrayal. However, it also means that the mesa code is making implicit assumptions regarding the attribute to which the space is assigned in the model, and how (depending on the used space class) it is to be visualized. Moreover, it makes space visualization not easily extendable by the user. So, I suggest changing the signature to
If space_portrayal is None, we can use the existing if elif structure in SpaceMatplotlib to identify the correct space_portrayal function (probably moved into a separate helper function). Likewise, if space is None, we can fall back on checking model.grid and model.space. This same more fine grained API can also be applied to make_space_altair. @Corvince, @EwoutH, any thoughts?
The text was updated successfully, but these errors were encountered:
The current signature for displaying a space is
This gives the user explicit control over the
agent_portraya
l and thepropertylayer_portrayal
. However, it also means that the mesa code is making implicit assumptions regarding the attribute to which the space is assigned in the model, and how (depending on the used space class) it is to be visualized. Moreover, it makes space visualization not easily extendable by the user. So, I suggest changing the signature toIf
space_portrayal
is None, we can use the existingif elif
structure inSpaceMatplotlib
to identify the correct space_portrayal function (probably moved into a separate helper function). Likewise, ifspace
is None, we can fall back on checkingmodel.grid
andmodel.space
. This same more fine grained API can also be applied tomake_space_altair
. @Corvince, @EwoutH, any thoughts?The text was updated successfully, but these errors were encountered: