DO NOT MERGE: Add optional title feature to ChartModule #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated docs to point to mesa-examples format fix
|
I'm not able to make this work after all. An experiment in https://github.com/projectmesa/mesa-examples/blob/main/examples/charts/charts/server.py is showing showing up in the javascript of the running example, but no resulting title text, and I don't know enough JavaScript to figure out why. Also, even if it worked, it looks not only like ChartVisualization.py, but also BarChartVisualization.py and PieChartVisualization.py (mabye everything in visualization/modules) would need corresponding changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes projectmesa/mesa-viz-tornado#23
Supersedes #955 - that code is fine, but old enough that rebasing with the current main seems hopeless.
Also, it includes an example that needs to be added to mesa-examples in a separate PR. When that PR is ready, will remove the "DO NOT MERGE" on this one.