Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper cancellation for perform_action #388

Open
mxgrey opened this issue Oct 9, 2024 · 0 comments
Open

Proper cancellation for perform_action #388

mxgrey opened this issue Oct 9, 2024 · 0 comments
Assignees

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Oct 9, 2024

Currently when a task cancellation happens while a perform_action is going on, RMF will immediately trigger the finished callback which does not give the underyling perform_action implementation an opportunity to respond to the cancellation before new commands get issued.

Ideally the underlying perform_action implementation should be able to block further execution of any commands until it is able to finish any cleanup behavior that it needs to do. We should endeavor to provide an API that lets users set a cancellation callback for their action, and the perform_action event will not trigger its finished callback until the cancellation callback has finished running.

@mxgrey mxgrey self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

No branches or pull requests

1 participant