Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implementation of FleetUpdateHandle::close_lanes() to automatically replan for robots if needed #248

Open
Yadunund opened this issue Nov 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Yadunund
Copy link
Member

Yadunund commented Nov 10, 2022

The FleetUpdateHandle::close_lanes() allows for lanes in the navigation graph of the fleet to be closed.

However the implementation does not currently replan the itinerary of a robot in the fleet that may be affected by a closure. Currently the fleet adapters have to implement logic to decide whether to replan. We can save a lot of repeated code in fleet adapter implementations if this logic was moved upstream.

@mxgrey do you see any issues with moving the replanning logic directly into theFleetUpdateHandle::close_lanes() implementation?

@Yadunund Yadunund added the enhancement New feature or request label Nov 10, 2022
@mxgrey
Copy link
Contributor

mxgrey commented Nov 10, 2022

I think it's a tricky situation because I don't think simply the fact that a lane is closing is enough information to tell us whether a robot which is moving down that lane should replan and potentially backtrack.

For example, if the lane is being closed because an obstacle has appeared in the middle of the lane, then a robot which is on that lane but past the obstacle should not replan.

For simplifying high-level decisions like this, I might suggest that we can put the replanning logic into the EasyFullControl with a lane-closing API that requires users to specify an obstacle location so that the EasyFullControl adapter knows how to make the right decision.

@Yadunund
Copy link
Member Author

That sounds good 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants