Add plugin: Floating Gifs

[mickeydarrenlau]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Darren-project/floating-gifs

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ObsidianReviewBot]

The automated review has not found any issues with your code, assigning human for additional review.

[joethei]

Why not just open the image in Obsidian and drag the pane to that corner?

"description": "A plugin that allows you to float gifs on your screen.",
Avoid including sentences like "This is a plugin that does ..." in your description, it should be self-evident that this is a plugin for Obsidian.
We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.

// Remember to rename these classes and interfaces!
Remove this comment

SharedStuff, sharedstuff.get("float_gif").src = this.app.vault.adapter.getResourcePath(value);, sharedstuff.set("float_gif", float_gif), sharedstuff.get("float_gif").remove()
Just read the value from the settings object, instead of adding another useless layer.

.setName('GIF File')
Use sentence case in UI

[mickeydarrenlau]

Its not on top of every page And a extra pane

…

On Thu, 12 Sept 2024, 3:59 am Johannes Theiner, ***@***.***> wrote: Why not just open the image in Obsidian and drag the pane to that corner? "description": "A plugin that allows you to float gifs on your screen.", <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/manifest.json#L6> Avoid including sentences like "This is a plugin that does ..." in your description, it should be self-evident that this is a plugin for Obsidian. We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple . // Remember to rename these classes and interfaces! <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L3> Remove this comment SharedStuff <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L6>, sharedstuff.get("float_gif").src = this.app.vault.adapter.getResourcePath(value); <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L134>, sharedstuff.set("float_gif", float_gif) <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L95>, sharedstuff.get("float_gif").remove() <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L100-L101> Just read the value from the settings object, instead of adding another useless layer. .setName('GIF File') <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L126> Use sentence case in UI <https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI> — Reply to this email directly, view it on GitHub <#4118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO6YPGG2NSNRU7PRHRY2O73ZWCOIPAVCNFSM6AAAAABND4U26OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUGU4TCNBTGY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[mickeydarrenlau]

Also isn't the setting layer for UI settings and permanent data only

…

On Thu, 12 Sept 2024, 3:51 pm Darren Lau, ***@***.***> wrote: Its not on top of every page And a extra pane On Thu, 12 Sept 2024, 3:59 am Johannes Theiner, ***@***.***> wrote: > Why not just open the image in Obsidian and drag the pane to that corner? > > "description": "A plugin that allows you to float gifs on your screen.", > <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/manifest.json#L6> > Avoid including sentences like "This is a plugin that does ..." in your > description, it should be self-evident that this is a plugin for Obsidian. > We have published a guide for plugin descriptions to follow here: > https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple > . > > // Remember to rename these classes and interfaces! > <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L3> > Remove this comment > > SharedStuff > <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L6>, > sharedstuff.get("float_gif").src = > this.app.vault.adapter.getResourcePath(value); > <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L134>, > sharedstuff.set("float_gif", float_gif) > <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L95>, > sharedstuff.get("float_gif").remove() > <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L100-L101> > Just read the value from the settings object, instead of adding another > useless layer. > > .setName('GIF File') > <https://github.com/Darren-project/floating-gifs/blob/11db6eebb9bfffcd23dec95178ae8b27f58b30ff/main.ts#L126> > Use sentence case in UI > <https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI> > > — > Reply to this email directly, view it on GitHub > <#4118 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AO6YPGG2NSNRU7PRHRY2O73ZWCOIPAVCNFSM6AAAAABND4U26OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUGU4TCNBTGY> > . > You are receiving this because you modified the open/close state.Message > ID: ***@***.***> >

[github-actions]

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

[mickeydarrenlau]

No updates yet.

…

On Sun, 13 Oct 2024, 3:29 pm github-actions[bot], ***@***.***> wrote: Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates. — Reply to this email directly, view it on GitHub <#4118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO6YPGAHMWCV7S2M3PEM6JTZ3ION3AVCNFSM6AAAAABND4U26OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHA3DAOBTHE> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[joethei]

The filename is stored in the settings object, and in your sharedstuff object, that's unnecessary duplication.
Just access it from the settings object.