Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim key bindings setting is ignored for encrypted notes #148

Open
Thogor opened this issue Jan 30, 2024 · 5 comments
Open

Vim key bindings setting is ignored for encrypted notes #148

Thogor opened this issue Jan 30, 2024 · 5 comments
Labels
editor limitation The encrypted notes editor is basic and may never have all the rich features of the Obsidian editor feat-whole-note Feature: Whole note encryption in testing Released in a beta version for testing
Milestone

Comments

@Thogor
Copy link

Thogor commented Jan 30, 2024

First of all, thank you for the great plugin.
It's exactly what I needed.

I did encounter a minor issue however.

The "Vim key bindings" setting seems to be ignored when editing encrypted notes.
See screenshot below for the setting in question.

image

I'd be happy to help with a PR if you're open to collaboration.

@meld-cp meld-cp added editor limitation The encrypted notes editor is basic and may never have all the rich features of the Obsidian editor feat-whole-note Feature: Whole note encryption labels Mar 3, 2024
@meld-cp
Copy link
Owner

meld-cp commented Apr 6, 2024

Yeh, it was a limitation of the editor view I was using... I have been working on an update...

Please make a backup of your vault and test v2.4.0-beta if you can.

@meld-cp meld-cp added the in testing Released in a beta version for testing label May 18, 2024
@asynchroza
Copy link

@meld-cp should I be creating the notes in any particular way? VIM keybindings do not seem to be working even on 2.4.0-beta.

@asynchroza
Copy link

@meld-cp should I be creating the notes in any particular way? VIM keybindings do not seem to be working even on 2.4.0-beta.

Never mind me, I had to restart the plugin since the old one was still loaded.

@meld-cp
Copy link
Owner

meld-cp commented May 30, 2024

No problem @asynchroza, so does it work ok? I didn't test it.

@asynchroza
Copy link

No problem @asynchroza, so does it work ok? I didn't test it.

Yes. Keybindings working as expected.

@meld-cp meld-cp added this to the v2.4.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor limitation The encrypted notes editor is basic and may never have all the rich features of the Obsidian editor feat-whole-note Feature: Whole note encryption in testing Released in a beta version for testing
Projects
None yet
Development

No branches or pull requests

3 participants