Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming table-container to overflow-container #11857

Open
pepelsbey opened this issue Sep 25, 2024 · 0 comments
Open

Consider renaming table-container to overflow-container #11857

pepelsbey opened this issue Sep 25, 2024 · 0 comments
Labels
effort: small This task is a small effort. needs decision from engineering p2 We want to address this but may have other higher priority items.

Comments

@pepelsbey
Copy link
Member

Summary

There are two PR opened in rari and yari addressing the problem with overflowing <math display="block"> elements. Since table-container is not exclusive to tables anymore and might be useful for any oversized content, especially on mobile, it would make sense to rename it to something more universal like overflow-container.

It’s not just a CSS selector and a class name. There’s also a wrapTables function and an extra table-container-inner wrapper.

It might also be worth revisiting the container’s behavior to make it universal for any type of content, not just tables.

Overflowing content examples

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Sep 25, 2024
@fiji-flo fiji-flo added p2 We want to address this but may have other higher priority items. needs decision from engineering effort: small This task is a small effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small This task is a small effort. needs decision from engineering p2 We want to address this but may have other higher priority items.
Projects
None yet
Development

No branches or pull requests

2 participants