fix: add border color on search input field #11931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzygasper
force-pushed
the
11276-search-field-border
branch
from
3a8f94d
to
c91a888
Compare
… is more visible on safari mobile
jazzygasper
force-pushed
the
11276-search-field-border
branch
from
c91a888
to
d57cadc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11276
Problem
The search input field on the homepage was not very visible on mobile Safari because of a missing border color.
Solution
The search input field was using the default browser style for the border, which were inconsistent across browsers. I added a specific border color to the search input field to ensure consistent visibility, especially in mobile Safari.
Screenshots
Before
After
How did you test this change?
Tested on safari mobile (iphone), safari desktop, chrome desktop and firefox desktop.