You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that custom reports were archiving even after being deleted. Debugging, I ended up finding that if a single site ID is passed as the idSites argument, the removeInvalidationsFromDistributedList method doesn't handle it properly because of a TypeError on line 690.
What should happen?
Since the comment block says that int is an allowed type for idSites, the removeInvalidationsFromDistributedList should handle that as well, or the removeInvalidationsSafely method should wrap it with an array before passing isSites on to removeInvalidationsFromDistributedList.
How can this be reproduced?
Using CustomReports 5.0.17 or earlier do the following:
Create a new report
Note that the option record named ReArchiveList was updated to add the newly created report
Delete the newly created report
Note that the option record named ReArchiveList was not updated
Note that archiving is done for the deleted report the next time archiving runs
What happened?
I noticed that custom reports were archiving even after being deleted. Debugging, I ended up finding that if a single site ID is passed as the idSites argument, the
removeInvalidationsFromDistributedList
method doesn't handle it properly because of a TypeError on line 690.What should happen?
Since the comment block says that int is an allowed type for idSites, the
removeInvalidationsFromDistributedList
should handle that as well, or theremoveInvalidationsSafely
method should wrap it with an array before passing isSites on toremoveInvalidationsFromDistributedList
.How can this be reproduced?
Using CustomReports 5.0.17 or earlier do the following:
Matomo version
5.x-dev
PHP version
8.1.30
Server operating system
Ubuntu 22.04
What browsers are you seeing the problem on?
Not applicable (e.g. an API call etc.)
Computer operating system
Ubuntu 22.04
Relevant log output
No response
Validations
The text was updated successfully, but these errors were encountered: