Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce context.Context to resource.Builder #18

Open
dprotaso opened this issue Mar 9, 2021 · 4 comments
Open

Introduce context.Context to resource.Builder #18

dprotaso opened this issue Mar 9, 2021 · 4 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dprotaso
Copy link
Contributor

dprotaso commented Mar 9, 2021 •
edited
Loading

I don't see a way to provide a context.Context to the resource.Builder for the purposes of cancellation/timeout
@dprotaso
Copy link
Contributor Author

dprotaso commented Mar 9, 2021 •
edited
Loading

In addition I notice the resource.Helper has a bunch of context.TODO() and exposing that as param would allow requests to be cancelled.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@dprotaso
Copy link
Contributor Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 11, 2021
@valkyr13
Copy link

is this issue available to take up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dprotaso @k8s-ci-robot @valkyr13 @fejta-bot