Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerticalYearCalendar scrolling performance issue #588

Open
zeroarst opened this issue Sep 16, 2024 · 3 comments
Open

VerticalYearCalendar scrolling performance issue #588

zeroarst opened this issue Sep 16, 2024 · 3 comments

Comments

@zeroarst
Copy link

zeroarst commented Sep 16, 2024

Library information:

  • Version: 2.5.4
  • View or Compose module: VerticalYearCalendar

Describe the bug**

When using the VerticalYearCalendar, scrolling exhibits noticeable low frame rates (FPS).

To Reproduce (if applicable)

  • Open Example11Page in the sample app.
  • Scroll up and down through the calendar.
  • Observe that the scrolling is not smooth.

Note: I tested this on a Samsung S23 Ultra, so hardware limitations should not be a factor.

Expected behavior (if applicable)

Smooth scrolling on VerticalYearCalendar.

Screenshots? (if applicable)

In the example list, scrolling is relatively smooth, but this is not the case with the VerticalYearCalendar. You can view the comparison here: https://imgur.com/a/pv8g4mN

Additional information

@zeroarst zeroarst changed the title VerticalYearCalendar scorlling performance issue VerticalYearCalendar scrolling performance issue Sep 16, 2024
@a7asoft
Copy link

a7asoft commented Sep 16, 2024

@zeroarst Have you been able to solve this issue? I'm experiencing the same thing but in view module.

@zeroarst
Copy link
Author

zeroarst commented Sep 16, 2024

@a7asoft
No, I just posted it today. I tried setting monthColumn to 2 and used a simple Text composable in dayContent without an additional Box wrapper. It seems to slightly improve performance, but I'm not completely certain.

@kizitonwose
Copy link
Owner

Will look into possible optimizations for the year calendar when I have some time (the API is experimental). But I imagine it would be quite tricky without resorting to just drawing the entire thing directly on the canvas. Keep in mind that there are 400+ times (Including in/out dates and headers/footers) to render in each year. Probably looks better with paged scrolling instead of continuous scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants