Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions during validation hide follow-on issues #163

Open
prettybits opened this issue Jun 26, 2023 · 0 comments
Open

Exceptions during validation hide follow-on issues #163

prettybits opened this issue Jun 26, 2023 · 0 comments
Assignees
Milestone

Comments

@prettybits
Copy link

When an exception occurs during validation, e.g. due to a schema validation error this is currently reported as an issue for CSIP0 and further validation seems to be skipped and requirements report as passed.

E.g. I got a schema validation error due to faulty IDREFs:

{
    "specification" : "CSIP-2.0.4",
    "id" : "CSIP0",
    "name" : "METS Schema",
    "location" : "",
    "description" : "Validation of METS Schema",
    "cardinality" : "",
    "level" : "MUST",
    "testing" : {
      "outcome" : "FAILED",
      "issues" : [ "[SAXParseException] cvc-id.1: There is no ID/IDREF binding for IDREF 'DMDLOG_0001'. (file: /home/prettybits/SIPs/CSIP0/METS.xml, line: 46, column: 13)" ],
      "warnings" : [ ],
      "notes" : [ ]
    }
  }

and a passed check for CSIP23:

{
    "specification" : "CSIP-2.0.4",
    "id" : "CSIP23",
    "name" : "Type of link",
    "location" : "mets/dmdSec/mdRef[@xlink:type=’simple’]",
    "description" : "Attribute used with the value “simple”. Value list is maintained by the xlink standard.",
    "cardinality" : "1..1",
    "level" : "MUST",
    "testing" : {
      "outcome" : "PASSED",
      "issues" : [ ],
      "warnings" : [ ],
      "notes" : [ ]
    }
  }

even though that actually failed after fixing the reference issue with the errors reported in #162.

@hmiguim hmiguim added this to the Next Version milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants