Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues when downloading multiple feeds? #129

Open
SpangleLabs opened this issue Apr 11, 2024 · 2 comments
Open

UI issues when downloading multiple feeds? #129

SpangleLabs opened this issue Apr 11, 2024 · 2 comments

Comments

@SpangleLabs
Copy link

SpangleLabs commented Apr 11, 2024

Hey there,

I'm archiving a whole opml of podcast feeds, and I've noticed the user interface seems to have some issues when downloading multiple feeds?
I've got a few things, so I'll number them, but they're not in any particular order.

  1. Firstly, it prints the podcast title for a moment before going into downloading the episodes, but then erases that, so it's just a list of all episodes. Making it tricky to see which podcast it's actually up to, unless I recognise the episode titles.
    An example of this, switching from one feed to another, without keeping any message saying about that:
    image
    It momentarily has a message saying "Archive complete! Archiving feed {name}" between the two, but then that disappears.

  2. Also, it seems like the entire list of episodes refreshes every time, so the entire screen flashes and it seems to re-print hundreds of lines rather than just the last lines which are in progress? Could it just leave the completed download lines alone, rather than refreshing those ones?
    An example video:
    https://github.com/janw/podcast-archiver/assets/2192223/2d6f0649-f4c4-4e3f-b47c-99d68b288d2e

  3. Similarly, I've got it set to 4 concurrent downloads, but after a while I end up only seeing one or two progress bars at the bottom, presumably the other in-progress downloads are lost somewhere higher up, but is it possible it could keep the in progress ones at the bottom instead? I suppose that might mean the lines end up out of order, and might mean episodes of different feeds get mixed between eachother though, but having the in progress bars at the bottom seems worth that, I suppose, rather than being unsure which episodes might be downloading at the moment

  4. A minor issue, but something I noticed as I seem to have a lot of broken old feeds. I noticed that if the feed url is a 404 that the archiver logs the error and moves on to the next feed, which is good! But if the feed gives a DNS error, it seems the archiver throws an error and halts.
    An example of the former: https://www.ministryoftesting.com/feed/podcast
    An example of the latter: https://feeds.sounder.fm/1188/rss.xml
    I would drop the stack traces here, but they're very long

  5. Also very minor, but is it expected that opml files process in a random order? I was expecting the archiver to process the feeds in the order they're listed in the file

Thanks for this tool though, it does seem very nice!

@SpangleLabs SpangleLabs changed the title UI constantly reprints entire list of episodes UI issues when downloading multiple feeds? Apr 11, 2024
@SpangleLabs
Copy link
Author

Oh, another example of point 1, when refreshing the feeds and only downloading a couple, I see that it's actually just that the list of episode downloads gets printed again and appended to with every new feed, rather than being reset between them:
image
So it downloads 1 episode with the first feed, then prints that again for every subsequent feed, and when a later feed has another episode to download, it prints both, etc

@janw
Copy link
Owner

janw commented Apr 17, 2024

Thanks for the thorough report, I'll see to tackling the UI issues next. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants