Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in CI are failing due to context being closed #1468

Open
2 tasks
ankur22 opened this issue Oct 7, 2024 · 0 comments
Open
2 tasks

Tests in CI are failing due to context being closed #1468

ankur22 opened this issue Oct 7, 2024 · 0 comments
Labels
ci dx developer experience

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Oct 7, 2024

What?

In CI we're getting a lot of test failures which requires a rerun of the CI job for them to pass. We usually see something like this in the output:

--- FAIL: TestLifecycleGoto (0.00s)
    --- FAIL: TestLifecycleGoto/load (0.39s)
        lifecycle_wait_test.go:582: testBrowser: canceled

Example CI run: https://github.com/grafana/xk6-browser/actions/runs/11222847117/job/31196156631?pr=1456

Why?

This issue came about after we started working with the vu context to control the iteration's lifecycle.

How?

We need to take a look at the tests that fail and fix why the context is closing earlier than expected.

Tasks

Tasks

Related PR(s)/Issue(s)

No response

@ankur22 ankur22 added dx developer experience ci labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci dx developer experience
Projects
None yet
Development

No branches or pull requests

1 participant