Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parkinsans #8300

Open
9 tasks done
redstonedesign opened this issue Oct 10, 2024 · 8 comments
Open
9 tasks done

Add Parkinsans #8300

redstonedesign opened this issue Oct 10, 2024 · 8 comments
Assignees
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding P3
Milestone

Comments

@redstonedesign
Copy link

redstonedesign commented Oct 10, 2024

Font Project Git Repo URL:

https://github.com/redstonedesign/parkinsans

Description:

Parkinsans is a geometric sans serif designed for UK charity Parkinson’s UK. Energetic, human, accessible, approachable – Parkinsans embodies Parkinson’s UK’s relentless energy, whilst typographic quirks reflect the unique experience of every Parkinson’s journey. Consisting of 6 weights, Parkinsans is designed to grab attention at display sizes and provide an accessible, easy reading experience for short form copy. Designed by award-winning, London based creative agency Red Stone, Parkinsans is derived from Indian Type Foundry's Poppins.

Requirements:

By opening this issue, I confirm the project meets the following requirements:

  • The entire font project is available in a Github repository (repo) and licensed under the OFL

  • The source files are available in the repo

  • I am the sole copyright author of the entire project, or, all other copyright authors have licensed their work to me under the OFL

  • There are no "Reserved Font Names" in the OFL license information, or in the project documentation of any known upstream projects. If there are RFNs, they are not used in whole or in part in this family name, or, I want to discuss how Google can work with my use of them.

  • The family name is unique according to namecheck.fontdata.com

  • The font supports at least the Google Fonts 'Latin Core' glyphset from github.com/googlefonts/glyphsets (direct link)

  • The repo has the Google Fonts preferred upstream repo structure

  • I have read, agree with, and comply with, the full Google Fonts contributing requirements

  • I will maintain the repository and participate in the onboarding process (addressing, solving, and responding to issues, merging pull requests, etc)

Image:

Image

@redstonedesign
Copy link
Author

hey @emmamarichal , are you able to advise if we need to do anything else to get this added as a new font?

@m4rc1e m4rc1e reopened this Oct 16, 2024
@m4rc1e m4rc1e added the II Submission pending proposal for non-commissioned fonts suggested in the issue tracker label Oct 16, 2024
@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 16, 2024

Hey @redstonedesign.

Thank you for the submission. I will raise it in our onboarding meeting this week. I'll post back whether or not we accept the family (looks decent so it's likely).

Please be aware that onboarding the family may take some time and we may require further work in order for it to meet our criteria.

@davelab6
Copy link
Member

davelab6 commented Oct 16, 2024

This is wonderful work! Thanks @redstonedesign :)

I've marked this as accepted but I believe it may not happen until mid Q1. hope thats OK for you

@davelab6 davelab6 added I New Font II Accepted Non-commissioned projects that are accepted for onboarding P3 and removed II Submission pending proposal for non-commissioned fonts suggested in the issue tracker labels Oct 16, 2024
@davelab6 davelab6 added this to the 2025 Q1 milestone Oct 16, 2024
@emmamarichal emmamarichal self-assigned this Oct 17, 2024
@emmamarichal
Copy link
Collaborator

Hi @redstonedesign!

Thank you for this great submission! I took a quick look so you can be able to add some changes before Q1 :)

  • Glyphset
    There are some missing glyphs, to follow the GF Latin Core glyphset: /.notdef/periodcentered.loclCAT/periodcentered.loclCAT.case/caroncomb.alt/idotaccent
    Remark: the .notdef needs to contain outlines (a rectangle would be the best solution)

Image

  • Variable font
    When I will export the fonts, I'll generate a variable, this is the format we prefer. Nothing to do on your side, I just let you know.

  • Interpolation issues
    There is a interpolation issue with the eogonek.
    Image

-Kerning
There is no kerning at all, it would be great if you could add the main pairs :) Please let me know if you need some kerning proofs!

Image

  • Fontbakery report
    I copy paste here the fontbakery report, please try to solve the most of the fail and warns you can, but don't worry if there are still some, I'll solve them during the onboarding process.

FontBakery report

fontbakery version: 0.13.0a0

Check results

[22] Parkinsans_AW_Google[wght].ttf
🔥 FAIL Checking file is named canonically.
  • 🔥 FAIL

    Expected "Parkinsans[wght].ttf. Got Parkinsans_AW_Google[wght].ttf.


    [code: bad-filename]
⚠️ WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value
  • ⚠️ WARN

    GPOS table lacks kerning information.


    [code: lacks-kern-info]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 1 start point differs in glyph 'eogonek' between location wght=475 and location wght=800

- Contour 1 in glyph 'eogonek': becomes underweight between wght=475 and wght=800.

- Contour 1 point 14 in glyph 'eogonek' has a kink between location wght=475 and location wght=800

[code: interpolation-issues]

⚠️ WARN Are there caret positions declared for every ligature?
  • ⚠️ WARN

    This font lacks caret position values for ligature glyphs on its GDEF table.


    [code: lacks-caret-pos]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 476 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 655: plus

Width = 504: less

Width = 676: equal

Width = 492: greater

Width = 651: logicalnot

Width = 657: plusminus

Width = 591: multiply

Width = 637: divide

Width = 519: minus

Width = 487: approxequal

Width = 664: notequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- indianrupee

- turkishlira

[code: unreachable-glyphs]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at . does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, tifinagh, coptic, math
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, malayalam, tai-le, old-permic, canadian-aboriginal, coptic, syriac, math
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage 25 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext

[code: unreachable-subsetting]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
  • ⚠️ WARN

    No dotted circle glyph present


    [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: i̇ ǐ i̦̇ i̦̊ i̦̋ ǐ̦ i̧̇ i̧̊ i̧̋ ǐ̧ ĵ j̆ j̇ j̊ j̋ ǰ j̦̀ j̦́ ĵ̦ j̦̃

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Ekpeye (Latn, 226,000 speakers), Mundani (Latn, 34,000 speakers), Mfumte (Latn, 79,000 speakers), Zapotec (Latn, 490,000 speakers), Gulay (Latn, 250,478 speakers), Dii (Latn, 71,000 speakers), Koonzime (Latn, 40,000 speakers), Vute (Latn, 21,000 speakers), Ma’di (Latn, 584,000 speakers), Dan (Latn, 1,099,244 speakers), Navajo (Latn, 166,319 speakers), Bete-Bendi (Latn, 100,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Nateni (Latn, 100,000 speakers), Yala (Latn, 200,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Basaa (Latn, 332,940 speakers), Mango (Latn, 77,000 speakers), Nzakara (Latn, 50,000 speakers), South Central Banda (Latn, 244,000 speakers), Bafut (Latn, 158,146 speakers), Igbo (Latn, 27,823,640 speakers), Fur (Latn, 1,230,163 speakers), Ngbaka (Latn, 1,020,000 speakers), Cicipu (Latn, 44,000 speakers), Makaa (Latn, 221,000 speakers), Lugbara (Latn, 2,200,000 speakers), Aghem (Latn, 38,843 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ebira (Latn, 2,200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Ejagham (Latn, 120,000 speakers).

[code: soft-dotted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* Iogonek (U+012E): X=202.0,Y=1.0 (should be at baseline 0?)

* Lcaron (U+013D): X=273.5,Y=689.0 (should be at cap-height 690?)

* W (U+0057): X=220.0,Y=-1.0 (should be at baseline 0?)

* Wacute (U+1E82): X=220.0,Y=-1.0 (should be at baseline 0?)

* Wcircumflex (U+0174): X=220.0,Y=-1.0 (should be at baseline 0?)

* Wdieresis (U+1E84): X=220.0,Y=-1.0 (should be at baseline 0?)

* Wgrave (U+1E80): X=220.0,Y=-1.0 (should be at baseline 0?)

* acircumflex (U+00E2): X=338.0,Y=688.0 (should be at cap-height 690?)

* cdotaccent (U+010B): X=275.5,Y=691.5 (should be at cap-height 690?)

* cdotaccent (U+010B): X=340.5,Y=691.5 (should be at cap-height 690?)

* 30 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* turkishlira has a counter-clockwise outer contour

* turkishlira has a counter-clockwise outer contour

* turkishlira has a counter-clockwise outer contour

[code: ccw-outer-contour]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    .


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

Parkinsans_AW_Google[wght].ttf
Dehinted Size 76.8kb
Hinted Size 76.8kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 14 100 8 129 0
0% 0% 0% 6% 40% 3% 51% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@redstonedesign
Copy link
Author

Thanks @m4rc1e, @davelab6 and @emmamarichal for the kind feedback!

We appreciate the swift review, we’ll get started on fixing these issues today.

If there’s anything we can do to speed up the onboarding process to get the font live sooner it would be hugely appreciated!
Parkinson's UK (the UK's leading charity for the condition) are launching their new brand at the start of 2025. The charity largely relies on people with Parkinson's in local communities to create and share comms, anything we can do to get them set up in 2024, ahead of launch, would be super amazing. 🙏

@redstonedesign
Copy link
Author

Hey @emmamarichal, if you do have some recommended kerning proofs that we could use that’d be super helpful!

@vv-monsalve
Copy link
Collaborator

HI @redstonedesign Then there is the Octopus tool you can get familiar with, but particularly its sample text strings could be of great help for an extended revision.

@emmamarichal
Copy link
Collaborator

Hi @redstonedesign,
Here you can find some tools for checking at least the basic kerning :)

You can also find a lot of ressources here: https://typedesignresources.com/#proofing-tools

When we do the fonts QA, we use the gftools qa templates. You can also refer to these text strings:
Spacing-kerning_checks.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding P3
Projects
Status: Todo
Development

No branches or pull requests

5 participants