diff --git a/builtin/notes.c b/builtin/notes.c index 8c26e4552694ab..02cdfdf1c9da67 100644 --- a/builtin/notes.c +++ b/builtin/notes.c @@ -489,6 +489,8 @@ static int add(int argc, const char **argv, const char *prefix) OPT_CALLBACK_F('c', "reedit-message", &d, N_("object"), N_("reuse and edit specified note object"), PARSE_OPT_NONEG, parse_reedit_arg), + OPT_BOOL('e', "edit", &d.use_editor, + N_("edit note message in editor")), OPT_CALLBACK_F('C', "reuse-message", &d, N_("object"), N_("reuse specified note object"), PARSE_OPT_NONEG, parse_reuse_arg), @@ -667,6 +669,8 @@ static int append_edit(int argc, const char **argv, const char *prefix) OPT_CALLBACK_F('C', "reuse-message", &d, N_("object"), N_("reuse specified note object"), PARSE_OPT_NONEG, parse_reuse_arg), + OPT_BOOL('e', "edit", &d.use_editor, + N_("edit note message in editor")), OPT_BOOL(0, "allow-empty", &allow_empty, N_("allow storing empty note")), OPT_CALLBACK_F(0, "separator", &separator, diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh index 99137fb235731b..7f45a324faac06 100755 --- a/t/t3301-notes.sh +++ b/t/t3301-notes.sh @@ -1567,4 +1567,33 @@ test_expect_success 'empty notes do not invoke the editor' ' git notes remove HEAD ' +test_expect_success '"git notes add" with -m/-F invokes the editor with -e' ' + test_commit 19th && + GIT_EDITOR="true" git notes add -m "note message" -e && + git notes remove HEAD && + echo "message from file" >file_1 && + GIT_EDITOR="true" git notes add -F file_1 -e && + git notes remove HEAD +' + +test_expect_success 'git notes append with -m/-F invokes editor with -e' ' + test_commit 20th && + GIT_EDITOR="true" git notes add -m "initial note" -e && + GIT_EDITOR="true" git notes append -m "appended note" -e && + git notes remove HEAD && + echo "initial note" >note_a && + echo "appended note" >note_b && + GIT_EDITOR="true" git notes add -F note_a -e && + GIT_EDITOR="true" git notes append -F note_b -e && + git notes remove HEAD +' + +test_expect_success 'append note with multiple combinations of -m, -F and -e, invokes editor' ' + test_commit 21st && + echo "foo-file-1" >note_1 && + echo "foo-file-2" >note_2 && + GIT_EDITOR="true" git notes append -F note_1 -m "message-1" -F note_2 -m "message-2" -e && + git notes remove HEAD +' + test_done