Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access DB with a generic Provider #216

Open
liamaharon opened this issue Oct 15, 2024 · 0 comments · May be fixed by #218
Open

Access DB with a generic Provider #216

liamaharon opened this issue Oct 15, 2024 · 0 comments · May be fixed by #218

Comments

@liamaharon
Copy link
Contributor

The ProviderFactory type rbuilder uses internally for DB ops is deliberately not exposed by the reth node to services running in-process alongside it, making it impossible to access and forward the node's ProviderFactory to the rbuilder when creating it in-process.

To resolve this, usage of the concrete ProviderFactory can be replaced with a generic Provider trait bounded by whatever it needs from here. This should allow rbuilder core to support
the provider exposed by reth when run in-process, and also a ProviderFactory created when the DB connection is opened independent to the node out-of-process.

Note that as well as allowing rbuilder to run in-process, this is also a necessary step to support the new reth engine (default now in reth v1.1) which does not use the ProviderFactory.

@liamaharon liamaharon linked a pull request Oct 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant