Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing resolve in ImportlibResourcesConfigSource #2963

Open
1 task done
Eldalie opened this issue Oct 3, 2024 · 0 comments
Open
1 task done

[Bug] Missing resolve in ImportlibResourcesConfigSource #2963

Eldalie opened this issue Oct 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Eldalie
Copy link

Eldalie commented Oct 3, 2024

🐛 Bug

Description

in function is_config of hydra/_internal/core_plugins/importlib_resources_config_source.py.
at line 86 res = files.joinpath(config_path) : resolve is missing and thus ret = res.exists() and res.is_file() can be wrongly false as the file can exist.

Checklist

  • I checked on the latest version of Hydra

Expected Behavior

The same behavior as hydra/_internal/core_plugins/file_config_source.py where the path is corrected with realpath.

System information

  • Hydra Version : 1.3.2
  • Python version : 3.12
  • Virtual environment type and version : poetry 1.8.3
  • Operating system : Linux
@Eldalie Eldalie added the bug Something isn't working label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant