You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, amazing that ESLint Code Explorer exists 🙌 🚀 Any movement in this AST / static analysis tooling area is great to see ❤️ Very useful for rule and plugin authors.
What problem do you want to solve?
Currently, it is finicky to navigate through the AST sections on the right side.
What do you think is the correct solution?
What do you think about adopting the feature from AST explorer (see below) where changing the cursor position in the left pane causes the matching part of the AST in the right pane to be expanded and highlighted?
AST explorer feature video:
Screen.Recording.2024-10-03.at.15.32.14.mov
Participation
I am willing to submit a pull request for this change.
Additional comments
No response
The text was updated successfully, but these errors were encountered:
karlhorky
changed the title
Suggestion: On code cursor movement, highlight matching AST part
Suggestion: On code cursor movement, expand + highlight matching AST part
Oct 3, 2024
Yea we can consider implementing this feature but wanted to clarify a few doubts.
we want the option where we can select on code editor and the right panel shows appropriate node information?
do we want vice versa as well? where we click on the right panel's node info and the line in code editor is highlighted?
do we want the option that enables these auto focus?
more of how this works from what I saw on astexplorer
when a click is performed on left panel the location of the cursor is marked
we manually walk through nodes and find if the node has start and end key in their range
if the node is inside this range then we mark the accordion to be open and then we recursively do the same operation until there are no further children
Yea we can consider implementing this feature but wanted to clarify a few doubts.
* we want the option where we can select on code editor and the right panel shows appropriate node information?
Yes
* do we want vice versa as well? where we click on the right panel's node info and the line in code editor is highlighted?
Yes
* do we want the option that enables these auto focus?
That would require some changes to the design, so I'd say let's leave this off for now and address this as a separate enhancement later if people request to be able to disable this behavior.
First of all, amazing that ESLint Code Explorer exists 🙌 🚀 Any movement in this AST / static analysis tooling area is great to see ❤️ Very useful for rule and plugin authors.
What problem do you want to solve?
Currently, it is finicky to navigate through the AST sections on the right side.
What do you think is the correct solution?
What do you think about adopting the feature from AST explorer (see below) where changing the cursor position in the left pane causes the matching part of the AST in the right pane to be expanded and highlighted?
AST explorer feature video:
Screen.Recording.2024-10-03.at.15.32.14.mov
Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: