Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(formula): fix some bug #3774

Merged
merged 4 commits into from
Oct 17, 2024
Merged

fix(formula): fix some bug #3774

merged 4 commits into from
Oct 17, 2024

Conversation

wpxp123456
Copy link
Contributor

close #3772
close https://github.com/dream-num/univer-pro/issues/2894
close https://github.com/dream-num/univer-pro/issues/2440
close https://github.com/dream-num/univer-pro/issues/2212

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Oct 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 7 seconds
commit  7a20f27
info  For more information, see full report

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.90909% with 15 lines in your changes missing coverage. Please review.

Project coverage is 30.97%. Comparing base (e1aeec0) to head (7a20f27).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/engine-formula/src/services/runtime.service.ts 0.00% 5 Missing ⚠️
...la-ui/src/controllers/formula-render.controller.ts 0.00% 4 Missing ⚠️
...ormula/src/engine/value-object/primitive-object.ts 85.00% 3 Missing ⚠️
...src/controllers/formula-alert-render.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #3774   +/-   ##
=======================================
  Coverage   30.96%   30.97%           
=======================================
  Files        2286     2286           
  Lines      118558   118580   +22     
  Branches    26113    26125   +12     
=======================================
+ Hits        36714    36726   +12     
- Misses      81844    81854   +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Oct 17, 2024
@wpxp123456 wpxp123456 merged commit 4c4efe4 into dev Oct 17, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the fix/formula-some-bug branch October 17, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dushusir Dushusir Dushusir approved these changes

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] formula if issue
3 participants
@wpxp123456 @Dushusir @oumomomo