Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Specific Avif image fails to load #23316

Open
armanimichael opened this issue Jun 27, 2024 · 10 comments · May be fixed by #25376
Open

Android: Specific Avif image fails to load #23316

armanimichael opened this issue Jun 27, 2024 · 10 comments · May be fixed by #25376
Assignees
Labels
area-image Image loading, sources, caching p/3 Work that is nice to have platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@armanimichael
Copy link

Description

Hello, I'm having a peculiar issue where a very specific image is not loading in on Android.

  • Avif format
  • Other Avif format images do work correctly
  • Converting the image to other formats "fixes" the issue, although this is not an actionable solution
  • Regardless of URI / File source type.

By digging into this a bit, it looks like Glide is failing to load the image. Yet, there's nothing suggesting why this is happening.

From the sample project, you'll see how there's simply a blank space where the image is supposed to be:
Screenshot 2024-06-27 at 14 37 01

Steps to Reproduce

No response

Link to public reproduction project repository

https://github.com/armanimichael/maui-image-sample

Version with bug

8.0.61 SR6.1

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

No response

Did you find any workaround?

No

Relevant log output

No response

@armanimichael armanimichael added the t/bug Something isn't working label Jun 27, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@RoiChen001 RoiChen001 added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jun 28, 2024
@RoiChen001
Copy link

I can repro this issue at Android platform on the latest 17.11.0 Preview 2.1(8.0.61).

@jfversluis jfversluis added the area-image Image loading, sources, caching label Jun 28, 2024
@jfversluis jfversluis added this to the Backlog milestone Jun 28, 2024
@jfversluis jfversluis added the p/3 Work that is nice to have label Jun 28, 2024
@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 3, 2024
@samhouts samhouts added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 10, 2024
@albyrock87
Copy link
Contributor

I've opened an issue on the appropriate repository to add the NuGet package for AVIF support.
When available also remember about: bumptech/glide#5140 (comment)

@moljac moljac self-assigned this Aug 6, 2024
@moljac
Copy link
Contributor

moljac commented Aug 6, 2024

@armanimichael @albyrock87

Does AVIF work on other platofrms?

@albyrock87
Copy link
Contributor

@moljac on iOS it does work, I have to information regarding other platforms

@moljac
Copy link
Contributor

moljac commented Aug 6, 2024

@armanimichael @albyrock87

Are you sure that just by adding new package this will be resolved?

@albyrock87
Copy link
Contributor

@moljac unfortunately I couldn't try this due to the missing NuGet package.

I'll try to see if I can create a java app in order to verify this.

My assumption is simply based on Glide's documentation.
To fix this issue we need the NuGet and then we have to modify the Gradle configuration so that Glide "sees" that plugin. Automatic plugin loading is also explained in Glide docs.

@moljac
Copy link
Contributor

moljac commented Aug 7, 2024

@moljac unfortunately I couldn't try this due to the missing NuGet package.

No. No. There is no nuget. Sorry for confusion

I'll try to see if I can create a java app in order to verify this.

Please do not waste your time. I created new bindings, but dependecy package is using some crazy versioning format which is not SemVer 2 nor Nuget legacy, so I need to fix tooling 1st.

My assumption is simply based on Glide's documentation. To fix this issue we need the NuGet and then we have to modify the Gradle configuration so that Glide "sees" that plugin.

This "seeing" part worries me. There is no Gradle when using nuget package. Hopefully we don't have to add too much. We'll see after bindings are ready.

Automatic plugin loading is also explained in Glide docs.

Plugin in Maven usually indicates that MSBuild tasks (tricks and hacks) will be needed.

@moljac
Copy link
Contributor

moljac commented Oct 18, 2024

@albyrock87

NuGet package has been published:

https://www.nuget.org/packages/Xamarin.Android.Glide.AVIF.Integration

Tried adding nuget package, but did not work.

Repro sample[s]:

Archive.zip

@moljac moljac linked a pull request Oct 18, 2024 that will close this issue
@moljac
Copy link
Contributor

moljac commented Oct 18, 2024

PR created

#25376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-image Image loading, sources, caching p/3 Work that is nice to have platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants