Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting TLS settings on the underlying HTTPS agent #197

Open
sidfarkus opened this issue Oct 23, 2023 · 0 comments
Open

Allow setting TLS settings on the underlying HTTPS agent #197

sidfarkus opened this issue Oct 23, 2023 · 0 comments
Labels
Component: Core Issues related to DBSQLClient, DBSQLSession, and DBSQLOperation enhancement New feature or request

Comments

@sidfarkus
Copy link

Currently the settings for a custom certificate or two-way SSL are implemented on the IConnectionOptions interface but they don't surface back up to an object that the user of the library can easily manipulate; for example in ConnectionOptions. I think these options should be settable when establishing a new connection in https://github.com/databricks/databricks-sql-nodejs/blob/main/lib/DBSQLClient.ts#L120C16-L120C23

A workaround is to bypass the 'private' protections on DBSQLClient.getConnectionOptions but that is non-ideal.
@kravets-levko kravets-levko added enhancement New feature or request Component: Core Issues related to DBSQLClient, DBSQLSession, and DBSQLOperation labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Core Issues related to DBSQLClient, DBSQLSession, and DBSQLOperation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sidfarkus @kravets-levko